The current css classes have
twiki
in the name. We can think of a different name of course - but it should be unique to prevent overlapping with other css code.
That is the easy part.
The difficult part is this problem: we stop being compatible with twiki.org extensions. Some extensions will assume a css class that is not defined by the shipped skins.
--
ArthurClemens - 08 Nov 2008 - 14:19
I think that we need to rename. But maybe we can create a TWikiCompatibilityContrib or plugin that provides the mechanisms needed.
In case of CSS this means an additional CSS file with all those twiki prefixed items.
Crazy idea? Possible? Just my 2 cents. Maybe it is a crazy way.
--
KennethLavrsen - 08 Nov 2008 - 15:01
Multiple files cannot be maintained. The suggestion on IRC to have each css definition double may provide an way out. For example:
.newNameTextarea,
.newNameInputField,
.newNameInputFieldDisabled,
.newNameInputFieldReadOnly,
.twikiTextarea, /* deprecated */
.twikiInputField, /* deprecated */
.twikiInputFieldDisabled, /* deprecated */
.twikiInputFieldReadOnly /* deprecated */ {
font-size:100%;
}
--
ArthurClemens - 08 Nov 2008 - 16:53
This is the only oustanding rebranding problem in the code, so I've elevated it to Urgent (was Normal)
I have done classes 1 to 16 from
CascadingStyleSheets.
--
ArthurClemens - 30 Nov 2008
Argh, we need to revert the changes in
ClassificationPlugin,
NatEditPlugin,
NatSkin,
WikiWorkbenchContrib
and
JQueryTwistyPlugin as these are still maintained on clients' intranets runing TWiki. We did not yet arrive in
a Foswiki-only world.
--
MichaelDaum - 05 Dec 2008
I have reverted changes to private extensions. I will continue on shipped extensions only.
Done with all default shipped code. If someone wants to update css classes for himself, this is the search pattern I have used:
(twiki)(WebIndent|Unvisited|TopRow|Topic|TocTitle|Toc|TextareaRawView|Textarea|TableRow|TableOdd|TableEven|TableCol|Table|Summary|SubmitDisabled|Submit|SRRev|SRAuthor|SortedDescendingCol|SortedCol|SortedAscendingCol|Smallish|Small|Separator|SelectDisabled|Select|SearchTable|SearchResultCount|Right|RadioButton|PreviewArea|PopUp|PageForm|Page|Notification|NoBreak|NewLink|New|MakeVisibleInline|MakeVisibleBlock|MakeVisible|MakeHidden|Main|Logo|Login|LinkLabel|LinkInHeaderRight|Link|Left|InputFieldReadOnly|InputFieldFocus|InputFieldDisabled|InputFieldBeforeFocus|InputField|Image|Hidden|Help|GrayText|FormTableRow|FormTableHRow|FormTableFooter|FormTable|FormSteps|FormStep|FormHolder|Form|FooterNote|Focus|FirstCol|EmulatedLink|EditForm|EditboxStyleProportional|EditboxStyleMono|DiffUnchangedTextContents|DiffUnchangedText|DiffTable|DiffLineNumberHeader|DiffDeletedText|DiffDeletedMarker|DiffDeletedHeader|DiffDebugRight|DiffDebugLeft|DiffDebug|DiffChangedText|DiffChangedHeader|DiffAddedText|DiffAddedMarker|DiffAddedHeader|CurrentWebHomeLink|CurrentTopicLink|ContentHeader|ContentFooter|Clear|Checkbox|ChangeFormButtonHolder|ChangeFormButton|ButtonDisabled|ButtonCancel|Button|BroadcastMessage|BottomRow|Attachments|AnchorLink|Alert|ActionFormStepSign|AccessKey|LastCol|Last|TableCol|TableRowdataBgSorted|TableRowdataBg)
Hits are of course replaced by
foswiki\2
.
Core extensions are done now.
As shown in Invalid svn rev, you removed all = from the TOPICINFO part of
CascadingStyleSheets.txt, which caused one warning:
view: Use of uninitialized value in pattern match (m//) at /.../core/lib/Foswiki/Store.pm line 1449, <FILE> chunk 1.
Re-opening to fix...